[ 
https://issues.apache.org/jira/browse/FLUME-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465997#comment-13465997
 ] 

Hari Shreedharan commented on FLUME-1491:
-----------------------------------------

Good work on the patch, some comments before we start a full review:
* AbstractConfigurationProvider and related classes should not be in 
flume-ng-core. Either leave them in the current package or move them to 
flume-ng-configuration. 
* Ideally flume-ng-configuration should not have dependencies on any other 
flume modules. The original idea was to allow this to be used for validating 
individual components' configuration. Eventually, I'd like to complete that 
work.
* The Zookeeper provider can simply be a separate package and not a submodule 
right? Do we need it to be a separate module - I am ok with either, just asking.

When you feel the patch is ready for review/commit, can you submit this for 
review on reviewboard?
                
> Dynamic configuration from Zookeeper watcher
> --------------------------------------------
>
>                 Key: FLUME-1491
>                 URL: https://issues.apache.org/jira/browse/FLUME-1491
>             Project: Flume
>          Issue Type: Improvement
>          Components: Configuration
>    Affects Versions: v1.2.0
>            Reporter: Denny Ye
>            Assignee: Denny Ye
>              Labels: Zookeeper
>             Fix For: v1.3.0
>
>         Attachments: FLUME-1491-2.patch, FLUME-1491-3.patch
>
>
> Currently, Flume only support file-level dynamic configuration. Another 
> frequent usage in practical environment, we would like to manage 
> configuration with Zookeeper, and modify configuration from Web UI to stored 
> file in Zookeeper. 
> Flume should support this method with Zookeeper watcher.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to