[ 
https://issues.apache.org/jira/browse/FLUME-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473797#comment-13473797
 ] 

Hari Shreedharan commented on FLUME-1630:
-----------------------------------------

Brock,

A couple of concerns:
* It looks like certain components are annotated to be "Reusable." I think we 
should change this to "NonReusable." All existing components except the ones 
like MemoryChannel should be tagged as "NonReusable." 
** Any custom components written to exploit the current code of being 
automatically "cached" needs to be able to function without any code changes.
** Any change of behavior expected by custom components (without any code 
changes) would break backward compatibility and can *only* be done in a major 
release.
* So any components that do not save state should explicitly state as such.

* I suggest renaming "Reusable" to "Stateful"/"Stateless." or something like 
that.

I have not reviewed the whole patch, but this is something I noticed.
                
> Flume configuration code could be improved
> ------------------------------------------
>
>                 Key: FLUME-1630
>                 URL: https://issues.apache.org/jira/browse/FLUME-1630
>             Project: Flume
>          Issue Type: Sub-task
>          Components: Configuration
>    Affects Versions: v1.3.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>         Attachments: FLUME-1630-0.patch, FLUME-1630-1.patch
>
>
> 1) It's not currently possible to provide your own configuration source
> 2) All sinks/sources/channels are reused, even across re-configurations which 
> they are not used
> 3) The flume-ng-node module is very complex and starts many threads which are 
> not required. That is there are multiple life cycle supervisors.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to