[ 
https://issues.apache.org/jira/browse/FLUME-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474047#comment-13474047
 ] 

Brock Noland edited comment on FLUME-1630 at 10/11/12 11:50 AM:
----------------------------------------------------------------

First off I agree that backwards compatibility is very important. However, I 
believe this is an exceedingly rare case. In that I find it unlikely that there 
are custom components out there which require this behavior. Are we aware of 
any custom components exploiting this? It seems like this was a hack put in to 
support memory channel. As a developer, I would expect the new behavior as in 
the patch.
                
      was (Author: brocknoland):
    First off I agree that backwards compatibility is very important. However, 
I believe this is an exceedingly rare case. In that I find it unlikely that 
there are custom components out there which require this behavior. Are we aware 
of any custom components exploiting this?  I'd be surprised if there are 
components other than MemoryChannel which require this behavior. Since handling 
re-configuration is hard, I think the default should be to create a new 
instance.
                  
> Flume configuration code could be improved
> ------------------------------------------
>
>                 Key: FLUME-1630
>                 URL: https://issues.apache.org/jira/browse/FLUME-1630
>             Project: Flume
>          Issue Type: Sub-task
>          Components: Configuration
>    Affects Versions: v1.3.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>         Attachments: FLUME-1630-0.patch, FLUME-1630-1.patch
>
>
> 1) It's not currently possible to provide your own configuration source
> 2) All sinks/sources/channels are reused, even across re-configurations which 
> they are not used
> 3) The flume-ng-node module is very complex and starts many threads which are 
> not required. That is there are multiple life cycle supervisors.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to