[
https://issues.apache.org/jira/browse/FLUME-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474182#comment-13474182
]
Brock Noland commented on FLUME-1630:
-------------------------------------
I should have added, if there is a real probability that we will affect a
custom component, I am for your changes. When writing the patch, I thought
about the possible cases for which components would be affected and I came up
with the following:
1) Non-persistant channel
2) Source/sink which non-persistently buffers data
3) Source/Sink which has a bug in it about cleaning up resources
#1 seems incredibly unlikely given MemoryChannel
#2 is an anti-pattern and also seems unlikely since the channel is a buffer
#3 is a bug and I don't think we should worry about breaking theoretical bugs
That is how I came to the conclusion that only MemoryChannel would require this
behavior off the bat.
> Flume configuration code could be improved
> ------------------------------------------
>
> Key: FLUME-1630
> URL: https://issues.apache.org/jira/browse/FLUME-1630
> Project: Flume
> Issue Type: Sub-task
> Components: Configuration
> Affects Versions: v1.3.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-1630-0.patch, FLUME-1630-1.patch
>
>
> 1) It's not currently possible to provide your own configuration source
> 2) All sinks/sources/channels are reused, even across re-configurations which
> they are not used
> 3) The flume-ng-node module is very complex and starts many threads which are
> not required. That is there are multiple life cycle supervisors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
