----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7748/#review13034 -----------------------------------------------------------
Hey Roshan, we should add a pointer back to https://issues.apache.org/jira/browse/FLUME-1661 Also we need a more complex test case to ensure escaping of double-quotes and nested quotes works. Would be good to read those values from a properties file (we can check it into src/test/resources) so that the string decoding is the same as it would be with a Flume config file in normal use. - Mike Percy On Oct. 26, 2012, 6:15 p.m., Roshan Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7748/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2012, 6:15 p.m.) > > > Review request for Flume. > > > Description > ------- > > Added new optional config directive 'shell' for Exec Source. One can specify > how to invoke a shell to run the command (e.g. /bin/sh -c) . This is only > needed for commands that use features like wildcards, backticks, pipes, etc > that are supported by the shell. > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java 46f672f > > flume-ng-core/src/main/java/org/apache/flume/source/ExecSourceConfigurationConstants.java > 0ba0508 > flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java > 8bcf320 > flume-ng-doc/sphinx/FlumeUserGuide.rst 29ead84 > > Diff: https://reviews.apache.org/r/7748/diff/ > > > Testing > ------- > > Have added a few test cases for both simple and more complex commands. > > > Thanks, > > Roshan Naik > >
