----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7748/#review15760 -----------------------------------------------------------
Sorry for being so tardy. Below is a few review items, oeverall I think the patch looks quite good! flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java <https://reviews.apache.org/r/7748/#comment33919> nit: I understand the other member variables are not final, but since we are adding a new one, can we make this one final? flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java <https://reviews.apache.org/r/7748/#comment33918> +1 for moving this to shared methods. However, I cannot think of any other tests except the HBase tests which use static stuff. I think it makes sense if the static stuff is heavy weight but these objects are light weight. Let's stick with Before and After here. flume-ng-core/src/test/resources/test_command.txt <https://reviews.apache.org/r/7748/#comment33916> Let's add tests to test shell arithmetic and also the more modern $( ) proces substitution. flume-ng-doc/sphinx/FlumeUserGuide.rst <https://reviews.apache.org/r/7748/#comment33917> I like the term Required over Needed here. Also, typically the term backtick is used over back tick. - Brock Noland On Nov. 6, 2012, 9:52 p.m., Roshan Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7748/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2012, 9:52 p.m.) > > > Review request for Flume. > > > Description > ------- > > Added new optional config directive 'shell' for Exec Source. One can specify > how to invoke a shell to run the command (e.g. /bin/sh -c) . This is only > needed for commands that use features like wildcards, backticks, pipes, etc > that are supported by the shell. > > > This addresses bug https://issues.apache.org/jira/browse/FLUME-1661. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FLUME-1661 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java 46f672f > > flume-ng-core/src/main/java/org/apache/flume/source/ExecSourceConfigurationConstants.java > 0ba0508 > flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java > 8bcf320 > flume-ng-core/src/test/resources/test_command.txt PRE-CREATION > flume-ng-doc/sphinx/FlumeUserGuide.rst 3af400e > pom.xml 363c0e4 > > Diff: https://reviews.apache.org/r/7748/diff/ > > > Testing > ------- > > Have added a few test cases for both simple and more complex commands. > > > Thanks, > > Roshan Naik > >
