----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7748/ -----------------------------------------------------------
(Updated Nov. 6, 2012, 9:52 p.m.) Review request for Flume. Changes ------- Consolidating feedback from all comments into this patch. Description ------- Added new optional config directive 'shell' for Exec Source. One can specify how to invoke a shell to run the command (e.g. /bin/sh -c) . This is only needed for commands that use features like wildcards, backticks, pipes, etc that are supported by the shell. This addresses bug https://issues.apache.org/jira/browse/FLUME-1661. https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FLUME-1661 Diffs (updated) ----- flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java 46f672f flume-ng-core/src/main/java/org/apache/flume/source/ExecSourceConfigurationConstants.java 0ba0508 flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 8bcf320 flume-ng-core/src/test/resources/test_command.txt PRE-CREATION flume-ng-doc/sphinx/FlumeUserGuide.rst 3af400e pom.xml 363c0e4 Diff: https://reviews.apache.org/r/7748/diff/ Testing ------- Have added a few test cases for both simple and more complex commands. Thanks, Roshan Naik
