----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9427/#review16959 -----------------------------------------------------------
My only concern is that a client who doesn't know about compression cannot talk to a server with compression enabled. Is there any way to detect that the client is not compressed and handle it accordingly at the server? That way, all servers can enable compression and maintain backcompat with existing clients. - Mike Percy On Feb. 13, 2013, 5:02 p.m., Ted Malaska wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9427/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2013, 5:02 p.m.) > > > Review request for Flume. > > > Description > ------- > > Enhance NettyAvroRpcClient and the use of NettyServer to optionally use > compression > > Description: This JIRA will update AvroSource and NettyAvroRpcClient to > optionally use ZlibEncoder and ZlibDecoder to compress communications between > themselves. > > Patch Comment: Added compression options for both client and server. > Note compress has be turn on both client and server for it to work. > Client can have compression with out compression if compression level is set > to 0 > > > This addresses bug FLUME-1915. > https://issues.apache.org/jira/browse/FLUME-1915 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java dc18c5d > flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java > 4bf36e6 > flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java > cf9724c > > flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientConfigurationConstants.java > 1e642d8 > flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 5042d11 > flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java > 99ae010 > > Diff: https://reviews.apache.org/r/9427/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Ted Malaska > >
