----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9427/#review16982 -----------------------------------------------------------
Hey Ted, Since it doesn't look like we really have good hooks for specifying headers or dynamically changing the Netty pipeline, the implementation looks good. A few points of feedback: 1. Let's plumb the configuration parameters from the client down to the AbstractRpcSink.configure() method to enable compression at the Avro Sink level 2. How about a unit test for the Avro Sink with compression talking to an Avro Source with compression? 3. It would be great to update the user docs for the AvroSource & AvroSink @ flume-ng-doc/sphinx/FlumeUserGuide.rst and the RpcClient @ flume-ng-doc/sphinx/FlumeDeveloperGuide.rst 4. In order to enable extension in the future (such as support for snappy or some other compression codec), how about we change the config param compression-enabled to compression-type = none | zlib Does that sound alright? Regards, Mike - Mike Percy On Feb. 13, 2013, 5:02 p.m., Ted Malaska wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9427/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2013, 5:02 p.m.) > > > Review request for Flume. > > > Description > ------- > > Enhance NettyAvroRpcClient and the use of NettyServer to optionally use > compression > > Description: This JIRA will update AvroSource and NettyAvroRpcClient to > optionally use ZlibEncoder and ZlibDecoder to compress communications between > themselves. > > Patch Comment: Added compression options for both client and server. > Note compress has be turn on both client and server for it to work. > Client can have compression with out compression if compression level is set > to 0 > > > This addresses bug FLUME-1915. > https://issues.apache.org/jira/browse/FLUME-1915 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java dc18c5d > flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java > 4bf36e6 > flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java > cf9724c > > flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientConfigurationConstants.java > 1e642d8 > flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 5042d11 > flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java > 99ae010 > > Diff: https://reviews.apache.org/r/9427/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Ted Malaska > >
