----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9427/#review17583 -----------------------------------------------------------
Ship it! +1, lgtm, I am going to commit this. I have one request for a minor follow-up patch inline. flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java <https://reviews.apache.org/r/9427/#comment37291> Can we file a follow-up JIRA to make this only active when compressionType == none or null/empty? A validation / usability nit. - Mike Percy On Feb. 27, 2013, 4:34 a.m., Ted Malaska wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9427/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2013, 4:34 a.m.) > > > Review request for Flume. > > > Description > ------- > > Enhance NettyAvroRpcClient and the use of NettyServer to optionally use > compression > > Description: This JIRA will update AvroSource and NettyAvroRpcClient to > optionally use ZlibEncoder and ZlibDecoder to compress communications between > themselves. > > Patch Comment: Added compression options for both client and server. > Note compress has be turn on both client and server for it to work. > Client can have compression with out compression if compression level is set > to 0 > > > This addresses bug FLUME-1915. > https://issues.apache.org/jira/browse/FLUME-1915 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/sink/AbstractRpcSink.java > 52bd49b > flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java dc18c5d > flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java b9e59ef > flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java > 4bf36e6 > flume-ng-doc/sphinx/FlumeUserGuide.rst 8eb3734 > flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java > cf9724c > > flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientConfigurationConstants.java > 1e642d8 > flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 5042d11 > flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java > 99ae010 > > Diff: https://reviews.apache.org/r/9427/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Ted Malaska > >
