> On Jan. 28, 2013, 7:27 p.m., Brock Noland wrote: > > flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java, line > > 248 > > <https://reviews.apache.org/r/7748/diff/2/?file=186015#file186015line248> > > > > nit: I understand the other member variables are not final, but since > > we are adding a new one, can we make this one final? > > Roshan Naik wrote: > This cannot be final.. its value is set by the configure method. > > Brock Noland wrote: > Hmm I might have highlighted the wrong one, I mean the member variable of > ExecRunnable. > > Roshan Naik wrote: > That too cannot be final. Also wasn't introduced in this patch. > > Brock Noland wrote: > This is a trivial point, but we seem to talking past each other and as > such, I'd like to make sure we are on the same page. ExecRunnable->shell > (line 248 in exec source) It's set in the constructor, why cannot it be > final? It was also introduced in this patch.
I see it now ... the absence of right line number caused the confusion. - Roshan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7748/#review15760 ----------------------------------------------------------- On Nov. 6, 2012, 9:52 p.m., Roshan Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7748/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2012, 9:52 p.m.) > > > Review request for Flume. > > > Description > ------- > > Added new optional config directive 'shell' for Exec Source. One can specify > how to invoke a shell to run the command (e.g. /bin/sh -c) . This is only > needed for commands that use features like wildcards, backticks, pipes, etc > that are supported by the shell. > > > This addresses bug https://issues.apache.org/jira/browse/FLUME-1661. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FLUME-1661 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java 46f672f > > flume-ng-core/src/main/java/org/apache/flume/source/ExecSourceConfigurationConstants.java > 0ba0508 > flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java > 8bcf320 > flume-ng-core/src/test/resources/test_command.txt PRE-CREATION > flume-ng-doc/sphinx/FlumeUserGuide.rst 3af400e > pom.xml 363c0e4 > > Diff: https://reviews.apache.org/r/7748/diff/ > > > Testing > ------- > > Have added a few test cases for both simple and more complex commands. > > > Thanks, > > Roshan Naik > >
