----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10379/#review18998 -----------------------------------------------------------
flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchSink.java <https://reviews.apache.org/r/10379/#comment39479> Since you are retrieving the headers twice within the method, you could retrieve it once and store it in a final variable for use later. Also perform null checks before attempting to use the variable. There may be cases where the event has no headers. - Israel Ekpo On April 9, 2013, 5:59 p.m., Edward Sargisson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10379/ > ----------------------------------------------------------- > > (Updated April 9, 2013, 5:59 p.m.) > > > Review request for Flume and Hari Shreedharan. > > > Description > ------- > > This change gets the timestamp from the event and uses it (in UTC) to > determine the name of the index to write to. This is required to match the > behaviour of Logstash so that Kibana can find the log events. > The previous code would use the current time and would do it in the timezone > of the Flume agent's host. > > > This addresses bug FLUME-1782. > https://issues.apache.org/jira/browse/FLUME-1782 > > > Diffs > ----- > > flume-ng-doc/sphinx/FlumeUserGuide.rst 693c0d7 > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchSink.java > 1b3db14 > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSink.java > 94b95b1 > > Diff: https://reviews.apache.org/r/10379/diff/ > > > Testing > ------- > > All unit tests and integration tests pass. A snapshot using commit > 5b9d31f1ad228 and the patch for flume-1972 has passed our internal > integration tests using customisations. > > > Thanks, > > Edward Sargisson > >
