-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10379/
-----------------------------------------------------------

(Updated April 22, 2013, 8:47 p.m.)


Review request for Flume and Hari Shreedharan.


Changes
-------

Updated patch with new interface as requested. Incorporated flume-1972 patch in 
order to resolve the merge conflicts.


Description
-------

This change gets the timestamp from the event and uses it (in UTC) to determine 
the name of the index to write to. This is required to match the behaviour of 
Logstash so that Kibana can find the log events.
The previous code would use the current time and would do it in the timezone of 
the Flume agent's host.


This addresses bug FLUME-1782.
    https://issues.apache.org/jira/browse/FLUME-1782


Diffs (updated)
-----

  flume-ng-doc/sphinx/FlumeUserGuide.rst 38f2205 
  
flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchDynamicSerializer.java
 aa7ad39 
  
flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchEventSerializer.java
 dc6a093 
  
flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchEventSerializer2.java
 PRE-CREATION 
  
flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchExtractIdFromHeaderIdProvider.java
 PRE-CREATION 
  
flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchIdProvider.java
 PRE-CREATION 
  
flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchLogStashEventSerializer.java
 3638368 
  
flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchNullIdProvider.java
 PRE-CREATION 
  
flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchSink.java
 1b3db14 
  
flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchSinkConstants.java
 7f75e22 
  
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/AbstractElasticSearchSinkTest.java
 2edacdc 
  
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchDynamicSerializer.java
 43a4b12 
  
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchExtractIdFromHeaderIdProvider.java
 PRE-CREATION 
  
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchLogStashEventSerializer.java
 9dff4b0 
  
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSink.java
 94b95b1 

Diff: https://reviews.apache.org/r/10379/diff/


Testing
-------

All unit tests and integration tests pass. A snapshot using commit 
5b9d31f1ad228 and the patch for flume-1972 has passed our internal integration 
tests using customisations.


Thanks,

Edward Sargisson

Reply via email to