----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15163/ -----------------------------------------------------------
(Updated Nov. 2, 2013, 9:45 p.m.) Review request for Flume, Hari Shreedharan and Mike Percy. Changes ------- Changes made. If we split this into two jiras than it might make sense to have one be for the multiport source the other be for the tcp/udp sources. There really wasn't a good logical separation as when I added the keepFields to the multiport it just happened that the priority was included there. Not the case for tcp/udp. Which was the reason I wanted to go ahead and deprecate tcp source to make things easier to manage. Repository: flume-git Description ------- Here is a first pass at this. Please not that the functionality of all 3 sources was modified slightly such that with this patch we will now preserve the syslog priority as well as the timestamp and header. e.g. <10>2013-10-31T17:36:27.381-07:00 localhost.localdomain test UDP syslog data Diffs ----- flume-ng-core/src/main/java/org/apache/flume/source/MultiportSyslogTCPSource.java 884fd62 flume-ng-core/src/main/java/org/apache/flume/source/SyslogParser.java bf3305c flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java 7a12d27 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java f2ea932 flume-ng-core/src/test/java/org/apache/flume/source/TestMultiportSyslogTCPSource.java 680e592 flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogParser.java 258c2f1 flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java a6a1d5b flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java eae26ed flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 898096b flume-ng-doc/sphinx/FlumeUserGuide.rst e38bb67 Diff: https://reviews.apache.org/r/15163/diff/ Testing ------- Added a brand new TestSyslogUdp Class to verify functionality. Updated Syslog parser test to verify as well. File Attachments (updated) ---------------- https://reviews.apache.org/media/uploaded/files/2013/11/02/FLUME-2217.2.patch Thanks, Jeff jlord
