> On Dec. 4, 2013, 3:39 a.m., Mike Percy wrote: > > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogParser.java, > > line 80 > > <https://reviews.apache.org/r/15163/diff/3/?file=378701#file378701line80> > > > > This is actually a really good test. Can you please loop twice, once > > with keepFields = true, another with keepFields = false?
In order to loop once again with keepFields = false I will need to rebuild the messagebody in a different way that breaks out the priority for each message. Such that we can compare the messagebody sans Priority to the event body. - Jeff ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15163/#review29691 ----------------------------------------------------------- On Nov. 6, 2013, 1:49 a.m., Jeff jlord wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15163/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2013, 1:49 a.m.) > > > Review request for Flume, Hari Shreedharan and Mike Percy. > > > Repository: flume-git > > > Description > ------- > > Here is a first pass at this. > Please not that the functionality of all 3 sources was modified slightly such > that with this patch we will now preserve the syslog priority as well as the > timestamp and header. e.g. > <10>2013-10-31T17:36:27.381-07:00 localhost.localdomain test UDP syslog data > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/source/MultiportSyslogTCPSource.java > 884fd62 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogParser.java > bf3305c > flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java > 7a12d27 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java > 96a9e85 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java > f2ea932 > > flume-ng-core/src/test/java/org/apache/flume/source/TestMultiportSyslogTCPSource.java > 680e592 > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogParser.java > 258c2f1 > > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java > a6a1d5b > > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java > eae26ed > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java > 898096b > flume-ng-doc/sphinx/FlumeUserGuide.rst 3a3038c > > Diff: https://reviews.apache.org/r/15163/diff/ > > > Testing > ------- > > Added a brand new TestSyslogUdp Class to verify functionality. > Updated Syslog parser test to verify as well. > > > Thanks, > > Jeff jlord > >
