----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15163/#review30140 -----------------------------------------------------------
Ship it! +1, LGTM. Thanks for your persistence Jeff! Please attach the patch to the JIRA. - Mike Percy On Dec. 10, 2013, 12:23 a.m., Jeff jlord wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15163/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2013, 12:23 a.m.) > > > Review request for Flume, Hari Shreedharan and Mike Percy. > > > Repository: flume-git > > > Description > ------- > > Here is a first pass at this. > Please not that the functionality of all 3 sources was modified slightly such > that with this patch we will now preserve the syslog priority as well as the > timestamp and header. e.g. > <10>2013-10-31T17:36:27.381-07:00 localhost.localdomain test UDP syslog data > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/source/MultiportSyslogTCPSource.java > 884fd62 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogParser.java > bf3305c > flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java > 7a12d27 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java > 96a9e85 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java > f2ea932 > > flume-ng-core/src/test/java/org/apache/flume/source/TestMultiportSyslogTCPSource.java > 680e592 > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogParser.java > 258c2f1 > > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java > a6a1d5b > > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java > eae26ed > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java > 898096b > flume-ng-doc/sphinx/FlumeUserGuide.rst 8687cb7 > > Diff: https://reviews.apache.org/r/15163/diff/ > > > Testing > ------- > > Added a brand new TestSyslogUdp Class to verify functionality. > Updated Syslog parser test to verify as well. > > > Thanks, > > Jeff jlord > >
