----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52627/#review151993 -----------------------------------------------------------
flume-ng-doc/sphinx/FlumeUserGuide.rst (line 1334) <https://reviews.apache.org/r/52627/#comment220666> I don't think it's necessary to link to the Cloudera article (actually it's not a blog, it's the CDH release notes which are not really relevant to the upstream docs). The KAFKA JIRA should be fine. flume-ng-doc/sphinx/FlumeUserGuide.rst (line 3101) <https://reviews.apache.org/r/52627/#comment220669> I agree with Tristan that this information should not be repeated verbatim. I think we could simply add a link to this section (the channel section) from the source and sink component sections, but keep the component-specific examples where appropriate and helpful. flume-ng-doc/sphinx/FlumeUserGuide.rst (line 3158) <https://reviews.apache.org/r/52627/#comment220670> I don't know what this means. Can you clarify what CN and SAN are? Are they part of the JAAS spec or something? Can you hyperlink those terms to documentation or provide a reference to where we can find more relevant information? flume-ng-doc/sphinx/FlumeUserGuide.rst (line 3203) <https://reviews.apache.org/r/52627/#comment220665> nit: please add spaces around the equals signs for consistency, here and elsewhere - Mike Percy On Oct. 7, 2016, 6:27 a.m., Attila Simon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52627/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2016, 6:27 a.m.) > > > Review request for Flume. > > > Bugs: FLUME-2971 > https://issues.apache.org/jira/browse/FLUME-2971 > > > Repository: flume-git > > > Description > ------- > > The patch aims to extend the existing documentation of secure Kafka channel > with describing SSL+Plaintext setup as well as providing the whole package > (SSL+Kerberos+Plain) for KafkaSource and KafkaSink. > > > Diffs > ----- > > flume-ng-doc/sphinx/FlumeUserGuide.rst ab71d38 > > Diff: https://reviews.apache.org/r/52627/diff/ > > > Testing > ------- > > "mvn site" generated the user guide without an error message in the html. > Embedded links are checked not to be broken. > > Known to require attention: Content of the jaas file has to be checked > focusing on the requirement of the Client section in every setup. > > > Thanks, > > Attila Simon > >
