----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52627/#review151999 -----------------------------------------------------------
Nice work! FYI I copied the patched documentation into a GitHub gist for easy reading (v2 of the patch): https://gist.github.com/mpercy/40017fd82cc21af41ddb7cba2b2f4600 since GitHub knows how to render ReStructuredText. Consider posting a gist link to the rendered document for ease of review next time you make large documentation contributions like this. - Mike Percy On Oct. 7, 2016, 6:27 a.m., Attila Simon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52627/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2016, 6:27 a.m.) > > > Review request for Flume. > > > Bugs: FLUME-2971 > https://issues.apache.org/jira/browse/FLUME-2971 > > > Repository: flume-git > > > Description > ------- > > The patch aims to extend the existing documentation of secure Kafka channel > with describing SSL+Plaintext setup as well as providing the whole package > (SSL+Kerberos+Plain) for KafkaSource and KafkaSink. > > > Diffs > ----- > > flume-ng-doc/sphinx/FlumeUserGuide.rst ab71d38 > > Diff: https://reviews.apache.org/r/52627/diff/ > > > Testing > ------- > > "mvn site" generated the user guide without an error message in the html. > Embedded links are checked not to be broken. > > Known to require attention: Content of the jaas file has to be checked > focusing on the requirement of the Client section in every setup. > > > Thanks, > > Attila Simon > >
