> On Oct. 10, 2016, 4:06 p.m., Mike Percy wrote: > > flume-ng-doc/sphinx/FlumeUserGuide.rst, line 1337 > > <https://reviews.apache.org/r/52627/diff/3/?file=1526446#file1526446line1337> > > > > I don't think it's necessary to link to the Cloudera article (actually > > it's not a blog, it's the CDH release notes which are not really relevant > > to the upstream docs). The KAFKA JIRA should be fine.
fixed everywhere > On Oct. 10, 2016, 4:06 p.m., Mike Percy wrote: > > flume-ng-doc/sphinx/FlumeUserGuide.rst, line 3104 > > <https://reviews.apache.org/r/52627/diff/3/?file=1526446#file1526446line3104> > > > > I agree with Tristan that this information should not be repeated > > verbatim. I think we could simply add a link to this section (the channel > > section) from the source and sink component sections, but keep the > > component-specific examples where appropriate and helpful. Please see my comment on Tristan's summary. (Also discussed with Mike offline) > On Oct. 10, 2016, 4:06 p.m., Mike Percy wrote: > > flume-ng-doc/sphinx/FlumeUserGuide.rst, line 3206 > > <https://reviews.apache.org/r/52627/diff/3/?file=1526446#file1526446line3206> > > > > nit: please add spaces around the equals signs for consistency, here > > and elsewhere fixed - Attila ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52627/#review151993 ----------------------------------------------------------- On Oct. 10, 2016, 6:04 p.m., Attila Simon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52627/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 6:04 p.m.) > > > Review request for Flume. > > > Bugs: FLUME-2971 > https://issues.apache.org/jira/browse/FLUME-2971 > > > Repository: flume-git > > > Description > ------- > > The patch aims to extend the existing documentation of secure Kafka channel > with describing SSL+Plaintext setup as well as providing the whole package > (SSL+Kerberos+Plain) for KafkaSource and KafkaSink. > > > Diffs > ----- > > flume-ng-doc/sphinx/FlumeUserGuide.rst ab71d38 > > Diff: https://reviews.apache.org/r/52627/diff/ > > > Testing > ------- > > "mvn site" generated the user guide without an error message in the html. > Embedded links are checked not to be broken. > > Known to require attention: Content of the jaas file has to be checked > focusing on the requirement of the Client section in every setup. > > > Thanks, > > Attila Simon > >
