Github user pivotal-jbarrett commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/36#discussion_r103350610
  
    --- Diff: src/tests/cpp/security/Security.cpp ---
    @@ -41,16 +41,18 @@
     
     #include "security/CredentialGenerator.hpp"
     
    -namespace FwkSecurity {
    +#include <mutex>
    +#include <util/concurrent/spinlock_mutex.hpp>
    +
    +namespace apache {
    +namespace geode {
    +namespace client {
    +namespace testframework {
    +namespace security {
    --- End diff --
    
    Probably but I didn't want to change their current scope without 
understanding the test. I wanted to just correct the warning around `using 
namespace`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to