Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103352781
--- Diff: src/cppcache/src/CqQueryVsdStats.cpp ---
@@ -108,21 +98,21 @@ CqQueryStatType::CqQueryStatType()
////////////////////////////////////////////////////////////////////////////////
CqQueryVsdStats::CqQueryVsdStats(const char* cqqueryName) {
- CqQueryStatType* regStatType = CqQueryStatType::getInstance();
+ auto& regStatType = CqQueryStatType::getInstance();
- StatisticsType* statsType = regStatType->getStatType();
+ StatisticsType* statsType = regStatType.getStatType();
- GF_D_ASSERT(statsType != NULL);
+ GF_D_ASSERT(statsType != nullptr);
--- End diff --
`static_assert` is a compile time assertion. In this case the assertion
can't be resolved at compile time since the variables and functions involved
are not `constexpr`, templates or other compiler resolved things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
