Github user pivotal-jbarrett commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/36#discussion_r103351757
  
    --- Diff: src/cppcache/src/MapSegment.hpp ---
    @@ -41,6 +40,9 @@
     #include <ace/Versioned_Namespace.h>
     #include "TombstoneList.hpp"
     #include <unordered_map>
    +
    +#include "util/concurrent/spinlock_mutex.hpp"
    --- End diff --
    
    `"` includes are for "local" includes. If `spinlock_mutex` was an external 
library then `<` would be used.
    
    If "down here" means why the sub directories, then the answer is to be 
consistent with the namespace. The utility of that is debatable.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to