Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105010443
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -187,8 +215,18 @@ public boolean removeKey(ByteArrayWrapper key,
RedisDataType type, boolean cance
return this.stringsRegion.remove(key) != null;
} else if (type == RedisDataType.REDIS_HLL) {
return this.hLLRegion.remove(key) != null;
+ } else if (type == RedisDataType.REDIS_LIST) {
+ return this.destroyRegion(key, type);
+ } else if (type == RedisDataType.REDIS_SET) {
+ // remove the set
--- End diff --
I think the comment is redundant and the returns aren't necessary (&
distract from overall control flow).
A comment saying "sets & hashes get removed from the region they're put in
rather than destroying a region" would be fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
