Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105059140
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SPopExecutor.java
---
@@ -36,24 +37,26 @@ public void executeCommand(Command command,
ExecutionHandlerContext context) {
}
ByteArrayWrapper key = command.getKey();
- @SuppressWarnings("unchecked")
- Region<ByteArrayWrapper, Boolean> keyRegion =
- (Region<ByteArrayWrapper, Boolean>)
context.getRegionProvider().getRegion(key);
- if (keyRegion == null || keyRegion.isEmpty()) {
+ // getRegion(key);
+ Region<ByteArrayWrapper, Set<ByteArrayWrapper>> region =
getRegion(context);
--- End diff --
We still need to check the metadata region to determine whether to throw
WRONGTYPE or return nil.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
