Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105008854
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/ExecutionHandlerContext.java
---
@@ -135,8 +135,14 @@ private void writeToChannel(ByteBuf message) {
*/
@Override
public void channelRead(ChannelHandlerContext ctx, Object msg) throws
Exception {
- Command command = (Command) msg;
- executeCommand(ctx, command);
+ try {
+ Command command = (Command) msg;
+ executeCommand(ctx, command);
+ } catch (Exception e) {
+ logger.error(e);
--- End diff --
If we're going to be logging exceptions as they propagate, I'd like to
think about the best place to catch all of them and also it would be nice to
add a little error message so we know where we caught the exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
