-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35542/#review88410
-----------------------------------------------------------



gemfire-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java 
(line 1441)
<https://reviews.apache.org/r/35542/#comment140919>

    I think CliStrings has a bunch more START_SERVER_* constants that are not 
listed here. Will those also have this same problem? For example: 
START_SERVER__LOAD__POLL__INTERVAL


- Darrel Schneider


On June 16, 2015, 4:18 p.m., William Markito wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35542/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 4:18 p.m.)
> 
> 
> Review request for geode, Darrel Schneider and Kirk Lund.
> 
> 
> Bugs: GEODE-51
>     https://issues.apache.org/jira/browse/GEODE-51
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> hostname-for-clients property was being ignored by server startup, preventing 
> external clients to connect to the cache servers after connecting to the 
> locator.
> 
> 
> Diffs
> -----
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java
>  d5db59d 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java
>  68b2483 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherJUnitTest.java
>  5af33e1 
> 
> Diff: https://reviews.apache.org/r/35542/diff/
> 
> 
> Testing
> -------
> 
> Passed all JUnit tests.
> Manual verification using Docker-composer example.
> JMX MBean values are OK.
> 
> 
> Thanks,
> 
> William Markito
> 
>

Reply via email to