> On June 24, 2015, 12:35 a.m., Kirk Lund wrote: > > Ship It!
Issues were dropped because we're opening separate ticket to fix the "help" feature in the Locator/ServerLaunchers. - Kirk ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35542/#review89105 ----------------------------------------------------------- On June 20, 2015, 6:10 a.m., William Markito wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35542/ > ----------------------------------------------------------- > > (Updated June 20, 2015, 6:10 a.m.) > > > Review request for geode, Darrel Schneider and Kirk Lund. > > > Bugs: GEODE-51 > https://issues.apache.org/jira/browse/GEODE-51 > > > Repository: geode > > > Description > ------- > > hostname-for-clients property was being ignored by server startup, preventing > external clients to connect to the cache servers after connecting to the > locator. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java > d5db59d > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java > d5db59d > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java > d5ea8ab > > gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java > 68b2483 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherJUnitTest.java > 5af33e1 > > Diff: https://reviews.apache.org/r/35542/diff/ > > > Testing > ------- > > Passed all JUnit tests. > Manual verification using Docker-composer example. > JMX MBean values are OK. > > > File Attachments > ---------------- > > GEODE-51.patch v2 > > https://reviews.apache.org/media/uploaded/files/2015/06/20/01916fb1-9f7d-4847-8a10-59a9ac0824c5__GEODE-51.patch > > > Thanks, > > William Markito > >
