----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35542/#review88417 -----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java (line 1441) <https://reviews.apache.org/r/35542/#comment140925> Need to add this to helpMap. The other newer arguments that were added for cluster config also need to be added to helpMap. The LocatorLauncher is probably similarly effected (newer arguments missing from the helpMap). - Kirk Lund On June 16, 2015, 11:18 p.m., William Markito wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35542/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 11:18 p.m.) > > > Review request for geode, Darrel Schneider and Kirk Lund. > > > Bugs: GEODE-51 > https://issues.apache.org/jira/browse/GEODE-51 > > > Repository: geode > > > Description > ------- > > hostname-for-clients property was being ignored by server startup, preventing > external clients to connect to the cache servers after connecting to the > locator. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java > d5db59d > > gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java > 68b2483 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherJUnitTest.java > 5af33e1 > > Diff: https://reviews.apache.org/r/35542/diff/ > > > Testing > ------- > > Passed all JUnit tests. > Manual verification using Docker-composer example. > JMX MBean values are OK. > > > Thanks, > > William Markito > >
