----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36936/#review93593 -----------------------------------------------------------
Ship it! I think you accidently set the "bug" and "branch" to 142 instead of 172 on this review. Also, in the future, I think it would be better to not mix checkins for different tickets. I think the work for 110 and 141 had nothing to do with 172 so should have been checked in seperately. At the very least it should have been in a seperate git revision. Also if 110 and 141 have the same cause it seems like it would be good to close one as a duplicate of the other. Then you can work on both of them on one feature branch. If you find yourself referencing multiple GEODE-xxx numbers in the same commit then that is a good time to think about refactoring your commit into seperate revisions. Or if you are starting each sentence of your commit message with "Also...". - Darrel Schneider On July 30, 2015, 3:33 a.m., vivek bhaskar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36936/ > ----------------------------------------------------------- > > (Updated July 30, 2015, 3:33 a.m.) > > > Review request for geode and Shirish Deshmukh. > > > Bugs: GEODE-142 > https://issues.apache.org/jira/browse/GEODE-142 > > > Repository: geode > > > Description > ------- > > Fixing an intermittent failure as reported by closing cache after each > individual test. > > Also taking care to avoid an assertion failure that is reflected in GEODE-110 > and GEODE-141. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionState.java > bb6ae5f > > gemfire-core/src/test/java/com/gemstone/gemfire/disttx/DistTXDebugDUnitTest.java > ff0a506 > > gemfire-core/src/test/java/com/gemstone/gemfire/disttx/DistributedTransactionDUnitTest.java > 2522e63 > > Diff: https://reviews.apache.org/r/36936/diff/ > > > Testing > ------- > > ./gradlew gemfire-core:integrationTest -DintegrationTest.single=*DistTX*JUnit* > ./gradlew -DdistributedTest.single=DistTXDistributedTestSuite > gemfire-core:distributedTest > > > Thanks, > > vivek bhaskar > >
