> On July 31, 2015, 4:47 p.m., Darrel Schneider wrote: > > gemfire-core/src/test/java/com/gemstone/gemfire/disttx/DistTXDebugDUnitTest.java, > > line 65 > > <https://reviews.apache.org/r/36936/diff/1/?file=1025041#file1025041line65> > > > > It is not clear to me why: > > 1. you are closing the cache. Can you add a comment? > > 2. why you are only doing it in the controller jvm. Wouldn't it also be > > needed in the invokeInEveryVM? It looks like the test has special create > > code for each jvm.
Please review the new diff to close cache on all VMs - vivek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36936/#review93739 ----------------------------------------------------------- On Aug. 3, 2015, 12:19 p.m., vivek bhaskar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36936/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2015, 12:19 p.m.) > > > Review request for geode, Darrel Schneider and Shirish Deshmukh. > > > Bugs: GEODE-172 > https://issues.apache.org/jira/browse/GEODE-172 > > > Repository: geode > > > Description > ------- > > Fixing an intermittent failure as reported by closing cache after each > individual test. > > Also taking care to avoid an assertion failure that is reflected in GEODE-110 > and GEODE-141. > > > Diffs > ----- > > > gemfire-core/src/test/java/com/gemstone/gemfire/disttx/DistTXDebugDUnitTest.java > 668f1e6 > > gemfire-core/src/test/java/com/gemstone/gemfire/disttx/DistributedTransactionDUnitTest.java > 79d6f64 > > Diff: https://reviews.apache.org/r/36936/diff/ > > > Testing > ------- > > ./gradlew gemfire-core:integrationTest -DintegrationTest.single=*DistTX*JUnit* > ./gradlew -DdistributedTest.single=DistTXDistributedTestSuite > gemfire-core:distributedTest > > > Thanks, > > vivek bhaskar > >
