> On July 31, 2015, 4:35 p.m., Darrel Schneider wrote: > > gemfire-core/src/test/java/com/gemstone/gemfire/disttx/DistributedTransactionDUnitTest.java, > > line 75 > > <https://reviews.apache.org/r/36936/diff/1/?file=1025042#file1025042line75> > > > > I know you are commenting this out but make sure that if you have a > > unit test that ever sets a system property that you make sure you unset it. > > I think this was causing lots of other tests run in these same jvms to fail > > later because they had fine level logging enabled. > > In this test the tearDown2 needs to make sure and unset the system > > properties set by setUp. > > And done unset them by setting them to false. > > This still leaves the sys prop set just to a different value and may > > effect future tests. > > Instead use System.clearProperty(String). > > > > Instead of setting a system property to configure the cache it would be > > better to use something like > > com.gemstone.gemfire.cache30.CacheTestCase.getCache(CacheFactory) and > > configure the CacheFactory with the gemfire properties you want.
Please review the new diff to clear system property as you sugested. - vivek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36936/#review93737 ----------------------------------------------------------- On Aug. 3, 2015, 12:19 p.m., vivek bhaskar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36936/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2015, 12:19 p.m.) > > > Review request for geode, Darrel Schneider and Shirish Deshmukh. > > > Bugs: GEODE-172 > https://issues.apache.org/jira/browse/GEODE-172 > > > Repository: geode > > > Description > ------- > > Fixing an intermittent failure as reported by closing cache after each > individual test. > > Also taking care to avoid an assertion failure that is reflected in GEODE-110 > and GEODE-141. > > > Diffs > ----- > > > gemfire-core/src/test/java/com/gemstone/gemfire/disttx/DistTXDebugDUnitTest.java > 668f1e6 > > gemfire-core/src/test/java/com/gemstone/gemfire/disttx/DistributedTransactionDUnitTest.java > 79d6f64 > > Diff: https://reviews.apache.org/r/36936/diff/ > > > Testing > ------- > > ./gradlew gemfire-core:integrationTest -DintegrationTest.single=*DistTX*JUnit* > ./gradlew -DdistributedTest.single=DistTXDistributedTestSuite > gemfire-core:distributedTest > > > Thanks, > > vivek bhaskar > >
