> On Oct. 19, 2015, 7:14 p.m., Mark Bretl wrote: > > pulse/build.gradle, line 43 > > <https://reviews.apache.org/r/39445/diff/1/?file=1101140#file1101140line43> > > > > gemfire-core is using version 4.12. Can the version be upgraded from > > 4.10 to 4.12?
I'm not actively using junit in code so can easily rev-up the version. > On Oct. 19, 2015, 7:14 p.m., Mark Bretl wrote: > > pulse/build.gradle, line 44 > > <https://reviews.apache.org/r/39445/diff/1/?file=1101140#file1101140line44> > > > > What was the reason for using Tomcat here (line 41-43) instead of Jetty? > > > > Since we are compiling with Jetty, shouldn't we be testing with Jetty? Tomcat is used as a driver to host Pulse in standalone mode. If I understand correctly, Jetty is used for the two REST API webApps and Pulse in embedded mode. Once this test task is all-green, I can add a new test to start in Jetty (embedded-mode). Created a new JIRA (GEODE-448) for it. - Nitin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39445/#review103144 ----------------------------------------------------------- On Oct. 19, 2015, 6:35 p.m., Nitin Lamba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39445/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 6:35 p.m.) > > > Review request for geode, Dick Cavender, Tushar Khairnar, and Dan Smith. > > > Repository: geode > > > Description > ------- > > This includes several clean-ups for Pulse tests including: > - Build gradle (to invoke the right set of tests) > - Pulse JMX test beans update based on Geode JMX changes in recent releases > - Test references (corrected or ignored) > > Still a few more clean-ups pending. This is an WIP commit on feature/GEODE-12 > branch. > > > Diffs > ----- > > pulse/build.gradle b2bd5fc > > pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/JMXDataUpdater.java > 27aed67 > pulse/src/main/resources/pulse.properties 17299c2 > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/Member.java > 812e055 > > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAutomatedTests.java > 21c14d5 > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTestData.java > d1a92a2 > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTests.java > b6dd7c6 > > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/RegionOnMember.java > 7402a8b > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/ServerObject.java > 97acac7 > > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/ServerObjectMBean.java > 9487c0e > pulse/src/test/resources/test.properties fabeea1 > > Diff: https://reviews.apache.org/r/39445/diff/ > > > Testing > ------- > > Tests done on local setup. A total of 4 tests are failing, down from 28 > initially. > > > Thanks, > > Nitin Lamba > >
