----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39445/#review104160 -----------------------------------------------------------
pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/JMXDataUpdater.java (line 2350) <https://reviews.apache.org/r/39445/#comment162438> We can Remove gemXD realated code completely from Geode pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTests.java (line 258) <https://reviews.apache.org/r/39445/#comment162439> Lot of test fail due to id/selection not found error mainly bcoz targeted elements are not visible or present in DOM. To avoid that test when checking for particular view should first navigate to that view by clicking some button or widget to make it visible. PulseAutomatedTests have lot of navigatTo** methods. Optionally if you can separate out all tests inside PulseTests class and run as a separate test it would avoid issues where test is at different html page/html view/html widget. All tests in Pulsetests expect current page to be default dashboard which may not be the case bcoz tests in PulseAutomatedTests navigate to lot of differnt pages. pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTests.java (line 293) <https://reviews.apache.org/r/39445/#comment162437> We should remove GemXD realated tests completely - Tushar Khairnar On Oct. 19, 2015, 6:35 p.m., Nitin Lamba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39445/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 6:35 p.m.) > > > Review request for geode, Dick Cavender, Tushar Khairnar, and Dan Smith. > > > Repository: geode > > > Description > ------- > > This includes several clean-ups for Pulse tests including: > - Build gradle (to invoke the right set of tests) > - Pulse JMX test beans update based on Geode JMX changes in recent releases > - Test references (corrected or ignored) > > Still a few more clean-ups pending. This is an WIP commit on feature/GEODE-12 > branch. > > > Diffs > ----- > > pulse/build.gradle b2bd5fc > > pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/JMXDataUpdater.java > 27aed67 > pulse/src/main/resources/pulse.properties 17299c2 > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/Member.java > 812e055 > > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAutomatedTests.java > 21c14d5 > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTestData.java > d1a92a2 > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTests.java > b6dd7c6 > > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/RegionOnMember.java > 7402a8b > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/ServerObject.java > 97acac7 > > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/ServerObjectMBean.java > 9487c0e > pulse/src/test/resources/test.properties fabeea1 > > Diff: https://reviews.apache.org/r/39445/diff/ > > > Testing > ------- > > Tests done on local setup. A total of 4 tests are failing, down from 28 > initially. > > > Thanks, > > Nitin Lamba > >
