----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39445/#review104301 -----------------------------------------------------------
One thing Dan observed is that eclipse files (.classpath, .project) are checked in git but they should not be can you add gitignore entries for them and remove them from git tracking - Tushar Khairnar On Oct. 28, 2015, 4:29 a.m., Nitin Lamba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39445/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2015, 4:29 a.m.) > > > Review request for geode, Dick Cavender, Tushar Khairnar, and Dan Smith. > > > Repository: geode > > > Description > ------- > > This includes several clean-ups for Pulse tests including: > - Build gradle (to invoke the right set of tests) > - Pulse JMX test beans update based on Geode JMX changes in recent releases > - Test references (corrected or ignored) > > This is set of 3 commits on feature/GEODE-12 branch. > > > Diffs > ----- > > pulse/build.gradle b2bd5fc > > pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/JMXDataUpdater.java > 27aed67 > pulse/src/main/resources/pulse.properties 17299c2 > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/Member.java > 812e055 > > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAutomatedTests.java > 21c14d5 > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTestData.java > d1a92a2 > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTests.java > b6dd7c6 > > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/RegionOnMember.java > 7402a8b > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/ServerObject.java > 97acac7 > > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/ServerObjectMBean.java > 9487c0e > pulse/src/test/resources/test.properties fabeea1 > > Diff: https://reviews.apache.org/r/39445/diff/ > > > Testing > ------- > > Tested with the latest Firefox browser 41.0.2. > All UI tests pass. > > > File Attachments > ---------------- > > Patch_02 - JUnit & gradle updates > > https://reviews.apache.org/media/uploaded/files/2015/10/28/4a2bf570-14f8-458d-9cc6-529d0f9b8f77__patch_02.diff > Patch_03 - Test clean-up & fixes > > https://reviews.apache.org/media/uploaded/files/2015/10/28/b5497b9a-8742-46e8-870e-a16e8622cebc__patch_03.diff > > > Thanks, > > Nitin Lamba > >
