----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40850/#review108859 -----------------------------------------------------------
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java (line 869) <https://reviews.apache.org/r/40850/#comment168320> Can these names be a bit more descriptive or have comments on what we are testing for instead of the number 2? gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java (line 913) <https://reviews.apache.org/r/40850/#comment168321> I think i have a similar test in my diff on reviewboard without the sleep. I'd like to avoid the sleep if at all possible - Jason Huynh On Dec. 3, 2015, 6:50 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40850/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2015, 6:50 p.m.) > > > Review request for geode, anilkumar gingade, Bruce Schuchardt, Jason Huynh, > and Jianxia Chen. > > > Repository: geode > > > Description > ------- > > GMSJoinLease junit tests > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 2f9c514 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java > e49e4ae > > Diff: https://reviews.apache.org/r/40850/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
