Is there a way to a sync mechanism (wait/notify, latch, etc) instead of sleep? Using sleep() means the test will fail unpredictably.
Anthony > On Dec 3, 2015, at 11:23 AM, Hitesh Khamesra <[email protected]> wrote: > > > >> On Dec. 3, 2015, 6:55 p.m., Jason Huynh wrote: >>> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java, >>> line 913 >>> <https://reviews.apache.org/r/40850/diff/2/?file=1153051#file1153051line913> >>> >>> I think i have a similar test in my diff on reviewboard without the >>> sleep. I'd like to avoid the sleep if at all possible > > In this test NetworkPartitionMessage generated by view creator thread thus > needs sleep. > > > - Hitesh > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40850/#review108859 > ----------------------------------------------------------- > > > On Dec. 3, 2015, 6:50 p.m., Hitesh Khamesra wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/40850/ >> ----------------------------------------------------------- >> >> (Updated Dec. 3, 2015, 6:50 p.m.) >> >> >> Review request for geode, anilkumar gingade, Bruce Schuchardt, Jason Huynh, >> and Jianxia Chen. >> >> >> Repository: geode >> >> >> Description >> ------- >> >> GMSJoinLease junit tests >> >> >> Diffs >> ----- >> >> >> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java >> 2f9c514 >> >> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java >> e49e4ae >> >> Diff: https://reviews.apache.org/r/40850/diff/ >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Hitesh Khamesra >> >> >
signature.asc
Description: Message signed with OpenPGP using GPGMail
