----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40850/#review108883 -----------------------------------------------------------
I recommend using Awaitility: https://github.com/jayway/awaitility I've already added it to Geode and written several tests using it. Most of my tests are unfortunately languishing on (long-term) feature branches, but it looks like others have used it in OplogJUnitTest and AutoBalancerIntegrationJUnitTest on develop. The concept is similar to DistributedTestCase.WaitCriterion but Awaitility is much better and more versatile while being a commonly used standard library (it's even has some coverage in books on unit testing). -Kirk - Kirk Lund On Dec. 3, 2015, 6:50 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40850/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2015, 6:50 p.m.) > > > Review request for geode, anilkumar gingade, Bruce Schuchardt, Jason Huynh, > and Jianxia Chen. > > > Repository: geode > > > Description > ------- > > GMSJoinLease junit tests > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 2f9c514 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java > e49e4ae > > Diff: https://reviews.apache.org/r/40850/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
