----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44877/#review123921 -----------------------------------------------------------
Can anything be done not to have static versions of jars in the expected_jars.txt? This now introduces having to update two different places again for dependencies and if we move back to transitive dependencies, then we have to manage those as well. I am definitely for making sure we keep tracking of adding dependencies and what we include in the distribution, however, I can see this getting out of sync. Myabe that is way it needs to be though. - Mark Bretl On March 15, 2016, 6:23 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44877/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 6:23 p.m.) > > > Review request for geode, Anthony Baker and Jason Huynh. > > > Repository: geode > > > Description > ------- > > This allows us to make sure we don't accidentally start shipping jars > that we didn't intend to. > > > Diffs > ----- > > geode-assembly/src/test/java/com/gemstone/gemfire/BundledJarsJUnitTest.java > PRE-CREATION > geode-assembly/src/test/resources/expected_jars.txt PRE-CREATION > > Diff: https://reviews.apache.org/r/44877/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
