> On March 16, 2016, 8:17 p.m., Mark Bretl wrote: > > Can anything be done not to have static versions of jars in the > > expected_jars.txt? This now introduces having to update two different > > places again for dependencies and if we move back to transitive > > dependencies, then we have to manage those as well. I am definitely for > > making sure we keep tracking of adding dependencies and what we include in > > the distribution, however, I can see this getting out of sync. Myabe that > > is way it needs to be though.
Good point. I was a little worried that a dependency could change licenses as it changes versions. But the chance that someone would actually notice that even with this test is slim, so it's probably just better to not check the versions. I do want to have this test, because now we could be shipping dependencies that we don't declare in our .gradle files because they are transitive dependencies. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44877/#review123921 ----------------------------------------------------------- On March 16, 2016, 9:34 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44877/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 9:34 p.m.) > > > Review request for geode, Anthony Baker and Jason Huynh. > > > Repository: geode > > > Description > ------- > > This allows us to make sure we don't accidentally start shipping jars > that we didn't intend to. > > > Diffs > ----- > > geode-assembly/src/test/java/com/gemstone/gemfire/BundledJarsJUnitTest.java > PRE-CREATION > geode-assembly/src/test/resources/expected_jars.txt PRE-CREATION > > Diff: https://reviews.apache.org/r/44877/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
