> On March 16, 2016, 6:28 p.m., anilkumar gingade wrote: > > geode-assembly/src/test/java/com/gemstone/gemfire/BundledJarsJUnitTest.java, > > line 78 > > <https://reviews.apache.org/r/44877/diff/1/?file=1300497#file1300497line78> > > > > Does this work on Windows....Or can we ignore windows platform?
I think it should - that's just a regular expression for files ending in .jar. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44877/#review123905 ----------------------------------------------------------- On March 16, 2016, 1:23 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44877/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 1:23 a.m.) > > > Review request for geode, Anthony Baker and Jason Huynh. > > > Repository: geode > > > Description > ------- > > This allows us to make sure we don't accidentally start shipping jars > that we didn't intend to. > > > Diffs > ----- > > geode-assembly/src/test/java/com/gemstone/gemfire/BundledJarsJUnitTest.java > PRE-CREATION > geode-assembly/src/test/resources/expected_jars.txt PRE-CREATION > > Diff: https://reviews.apache.org/r/44877/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
