> On May 2, 2016, 11:46 p.m., Jason Huynh wrote: > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPROverflow.java, > > line 26 > > <https://reviews.apache.org/r/46918/diff/1/?file=1369345#file1369345line26> > > > > Remove?
Will do. > On May 2, 2016, 11:46 p.m., Jason Huynh wrote: > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java, > > line 101 > > <https://reviews.apache.org/r/46918/diff/1/?file=1369343#file1369343line101> > > > > For future reference, what happens if the region is a replicated > > region, does rebalance just get ignored? Hmm, yeah, maybe we need a better heirarchy of tests. PR specific tests should be in a subclass. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46918/#review131422 ----------------------------------------------------------- On May 2, 2016, 11:43 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46918/ > ----------------------------------------------------------- > > (Updated May 2, 2016, 11:43 p.m.) > > > Review request for geode, Jason Huynh, nabarun nag, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Refactoring this test into a framework for adding more tests with a > bunch of subclasses. > > > Diffs > ----- > > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPR.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPROverflow.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneFunctionReadPathDUnitTest.java > f6fcf8a36ea73218918c93192a98c60eae83ac0b > > Diff: https://reviews.apache.org/r/46918/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
