----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46918/#review131560 -----------------------------------------------------------
Fix it, then Ship it! geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java (line 60) <https://reviews.apache.org/r/46918/#comment195582> Should we pull the "createIndex" into it's own method call and not have it be part of initDataStore? The only reason why we might want to do that would be when we finally support creating indexes after the region has been created? - Jason Huynh On May 3, 2016, 12:12 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46918/ > ----------------------------------------------------------- > > (Updated May 3, 2016, 12:12 a.m.) > > > Review request for geode, Jason Huynh, nabarun nag, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Refactoring this test into a framework for adding more tests with a > bunch of subclasses. > > > Diffs > ----- > > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPRBase.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPR.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPROverflow.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneFunctionReadPathDUnitTest.java > f6fcf8a36ea73218918c93192a98c60eae83ac0b > > Diff: https://reviews.apache.org/r/46918/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
