> On May 3, 2016, 9:20 p.m., Jason Huynh wrote: > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java, > > line 60 > > <https://reviews.apache.org/r/46918/diff/2/?file=1369368#file1369368line60> > > > > Should we pull the "createIndex" into it's own method call and not have > > it be part of initDataStore? > > > > The only reason why we might want to do that would be when we finally > > support creating indexes after the region has been created?
The reason why I made the createIndex code a callback is that I wanted the test class to be able to decide when and if it should run it. I guess maybe that made more sense for the accessor VM, because an accessor could be a datastore or it could be a client depending on the topology we're testing. So maybe I should take it out of the initDataStore but leave it in initAccessor? I think maybe I'll leave them the same for the moment but we can refactor if we need to add different tests for different orders? - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46918/#review131560 ----------------------------------------------------------- On May 3, 2016, 12:12 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46918/ > ----------------------------------------------------------- > > (Updated May 3, 2016, 12:12 a.m.) > > > Review request for geode, Jason Huynh, nabarun nag, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Refactoring this test into a framework for adding more tests with a > bunch of subclasses. > > > Diffs > ----- > > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPRBase.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPR.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPROverflow.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneFunctionReadPathDUnitTest.java > f6fcf8a36ea73218918c93192a98c60eae83ac0b > > Diff: https://reviews.apache.org/r/46918/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
