Re: svn commit: r527746 - in /geronimo/server/trunk: assemblies/geronimo-boilerplate-minimal/src/main/resources/var/config/ modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/ modules/geronimo-deploy-tool/src/main/java/org/apache/ger...

[Donald Woods]

And how does the portOffset relate to this? If you start with 1098, isn't the next server instance going to use 1099 and the next one 1100? If so, why not start with 1099 and let the next one use 1100 and then 1101?

-Donald

Jason Dillon wrote:

It's not clear to me either why the RMI port default needs to be changed.... Do we not want one RMI registry to be shared by all server instances?

I don't get it... if we change the port to 1098... how then does some other instance of Geronimo need 1099... and not 1098?

--jason


On Apr 11, 2007, at 8:43 PM, Anita Kulshreshtha wrote:

Is there anything specific on the document you linked to which explains why we are changing the port? I quickly looked it over and nothing stands out as justification for us changing the defaults.

  In short, 1099 must be available to start other instances of
geronimo.
http://www.developer.com/java/ent/article.php/3455311

Thanks
Anita

--- Jason Dillon <[EMAIL PROTECTED]> wrote:

Why are we changing the port?

--jason


On Apr 11, 2007, at 7:33 PM, Donald Woods wrote:

Don't the following need to be updated too, given they are used
throughout the configs and assemblies?
  assemblies\pom.xml 42 25:        <PlanNamingPort>1099</
PlanNamingPort>
  configs\pom.xml 63 25:

<PlanNamingPort>1099</PlanNamingPort>

Also, other references to 1099 in the source -
modules\geronimo-deploy-jsr88\src\main\java\org\apache\geronimo
\deployment\plugin\factories\BaseDeploymentFactory.java
modules\geronimo-system\src\test\java\org\apache\geronimo\system
\properties\NamingPropertiesTest.java

User messages that should be updated -
modules\geronimo-deploy-tool\src\main\java\org\apache\geronimo
\deployment\cli\ServerConnection.java

Are you going to update the 2.0 User Docs to correctly show 1098 as

the new default port for the Deployer?
  http://cwiki.apache.org/GMOxDOC20/deployer-tool.html
  http://cwiki.apache.org/GMOxDOC20/shutdown.html


-Donald

[EMAIL PROTECTED] wrote:

Author: akulshreshtha
Date: Wed Apr 11 18:42:13 2007
New Revision: 527746
URL: http://svn.apache.org/viewvc?view=rev&rev=527746
Log:
GERONIMO-3011 Change default RMINaming port to 1098
  Added system property admin.disabled=true   Removed
PluginBootstrap, it was used by Maven1 build
Removed:
    geronimo/server/trunk/modules/geronimo-deploy-tool/src/main/
java/org/apache/geronimo/deployment/PluginBootstrap.java
Modified:
    geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/

src/main/resources/var/config/config-substitutions.properties
    geronimo/server/trunk/modules/geronimo-deploy-tool/src/main/
java/org/apache/geronimo/deployment/cli/StopServer.java
    geronimo/server/trunk/modules/geronimo-openejb/src/main/java/
org/apache/geronimo/openejb/OpenEjbSystemGBean.java
Modified: geronimo/server/trunk/assemblies/geronimo-boilerplate-

minimal/src/main/resources/var/config/config-substitutions.properties

URL:

http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/

geronimo-boilerplate-minimal/src/main/resources/var/config/config-

substitutions.properties?view=diff&rev=527746&r1=527745&r2=527746

=====================================================================

=========
--- geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/

src/main/resources/var/config/config-substitutions.properties
(original)
+++ geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/

src/main/resources/var/config/config-substitutions.properties Wed

Apr 11 18:42:13 2007
@@ -23,7 +23,7 @@
 ##   Try portOffset=10
 #portOffset=0
 PlanServerHostname=0.0.0.0
-PlanNamingPort=1099
+PlanNamingPort=1098
 PlanOpenEJBPort=4201
 PlanClientAddresses=127.0.0.1
 PlanIIOPPort=9000
Modified: geronimo/server/trunk/modules/geronimo-deploy-tool/src/
main/java/org/apache/geronimo/deployment/cli/StopServer.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/

cli/StopServer.java?view=diff&rev=527746&r1=527745&r2=527746

=====================================================================

=========
--- geronimo/server/trunk/modules/geronimo-deploy-tool/src/main/
java/org/apache/geronimo/deployment/cli/StopServer.java (original)
+++ geronimo/server/trunk/modules/geronimo-deploy-tool/src/main/
java/org/apache/geronimo/deployment/cli/StopServer.java Wed Apr 11

18:42:13 2007
@@ -40,7 +40,7 @@
      public static final String RMI_NAMING_CONFG_ID = "org/apache/
geronimo/RMINaming";
 -    public static final String DEFAULT_PORT = "1099";
+    public static final String DEFAULT_PORT = "1098"; // 1099 is
used by java.rmi.registry.Registry
      String port;
 Modified:

geronimo/server/trunk/modules/geronimo-openejb/src/main/

java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
geronimo-openejb/src/main/java/org/apache/geronimo/openejb/
OpenEjbSystemGBean.java?view=diff&rev=527746&r1=527745&r2=527746

=====================================================================

=========
--- geronimo/server/trunk/modules/geronimo-openejb/src/main/java/
org/apache/geronimo/openejb/OpenEjbSystemGBean.java (original)
+++ geronimo/server/trunk/modules/geronimo-openejb/src/main/java/
org/apache/geronimo/openejb/OpenEjbSystemGBean.java Wed Apr 11
18:42:13 2007
@@ -95,6 +95,7 @@
         this.classLoader = classLoader;
                  System.setProperty("duct tape","");
+        System.setProperty("admin.disabled", "true");
         SystemInstance systemInstance = SystemInstance.get();
          String format = systemInstance.getProperty
("openejb.deploymentId.format");

TV dinner still cooling?
Check out "Tonight's Picks" on Yahoo! TV.
http://tv.yahoo.com/

____________________________________________________________________________________

smime.p7s
Description: S/MIME Cryptographic Signature