[
https://issues.apache.org/jira/browse/GERONIMO-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531240
]
Anita Kulshreshtha commented on GERONIMO-3490:
----------------------------------------------
Thanks Viet for the patch! I played around with the patch a bit and have a few
more suggestions:
- 1. You should not need to compute the startTime from LastSampleTime.
- 2. When the statistics are not being collected, the starttime/LastsampleTime
shows:
Start Time: Wed Dec 31 19:00:00 EST 1969, i.e. the value 0. I am OK with all
0's in 'Empty' stats. We could change our stats portlet to display " for 0 ms.
WDYT?
- 3. Since the stats are disabled by default, I had to either go to 'webserver'
page to enable the container stats or set 'collectStatistics' attribute via
JMXViewer. After that I was able to view JettyContainerStats from JMXViewer. I
could not enable the connector stats from the console because the operation
"statsOn' threw exception. I could not view any real connector data. Do you
think we should add an enableStats button to "stats" page in JMXViewer?
It would be nice if you could fix #1.
> Missing Jetty Connector stats
> -----------------------------
>
> Key: GERONIMO-3490
> URL: https://issues.apache.org/jira/browse/GERONIMO-3490
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Jetty
> Affects Versions: 2.1
> Environment: windows xp
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3490.patch
>
>
> Jetty6 provides connector statistics, but they are not being surfaced in
> Geronimo's source code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
