[ 
https://issues.apache.org/jira/browse/GERONIMO-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viet Hung Nguyen updated GERONIMO-3490:
---------------------------------------

    Attachment: geronimo-3490b.patch

Anita, I tested the jetty connectors by turning it on from the jmxviewer also. 
I also get a NPE, but the operation actually turns the stats on. What I have 
realized from playing around with the jetty connector stats is that the 
statistics updates after you close the browser. So if you restart your browser 
and log back in to view the stats, the numbers should be jumping. 

I have attached a new patch which reflects the accurate startTime and 
lastsampletime attributes. I did some math to get the accurate startTime 
because I looked in jetty's source code and found out that there is a variable 
labeled 'statsStartedAt'

however, there isn't a method to get that exact value. there is getStatsOnMs() 
which returns exactly 

System.currentTime() - statsStartedAt (which is the total time that the stats 
have been collecting for)

So I did some manipulation on it to get just 'statsStartedAt.'

And I think having Start Time: Wed Dec 31 19:00:00 EST 1969 is very confusing 
too. So an empty string like you suggested  or something like "---" would also 
work.

Also, the jetty container stats are actually on by default. I have discussed 
this issue with joe, and we are still trying to figure out a good way to keep 
it off by default.

> Missing Jetty Connector stats
> -----------------------------
>
>                 Key: GERONIMO-3490
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3490
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Jetty
>    Affects Versions: 2.1
>         Environment: windows xp
>            Reporter: Viet Hung Nguyen
>            Assignee: Anita Kulshreshtha
>         Attachments: geronimo-3490.patch, geronimo-3490b.patch
>
>
> Jetty6 provides connector statistics, but they are not being surfaced in 
> Geronimo's source code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to