[
https://issues.apache.org/jira/browse/GERONIMO-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532491
]
Viet Hung Nguyen commented on GERONIMO-3490:
--------------------------------------------
Anita, I just tested out the new jetty connector stats. I think the stats seem
to work.
However, my biggest concern now is how you changed the isStatisticsProvider
attribute to depend on whether or not stats are actually being collected. By
default, Jetty Connector stats will be turned off, therefore the
isStatisticsProvider attribute for all jetty connectors will be false. If I was
someone who was not familiar with which stats Geronimo was capable of
providing, I will not be able to tell that Geronimo does in fact surface jetty
connector stats.
I think a way around this is to have another method (e.g. isStatsOn()) while
isStatisticsProvider is always true for mbeans that CAN provide statistics.
This way, the user can just query for all StatisticsProvider mbeans and turn
them on/off according to their likings.
> Missing Jetty Connector stats
> -----------------------------
>
> Key: GERONIMO-3490
> URL: https://issues.apache.org/jira/browse/GERONIMO-3490
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Jetty
> Affects Versions: 2.1
> Environment: windows xp
> Reporter: Viet Hung Nguyen
> Assignee: Anita Kulshreshtha
> Attachments: geronimo-3490.patch, geronimo-3490b.patch
>
>
> Jetty6 provides connector statistics, but they are not being surfaced in
> Geronimo's source code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
