Canceling this due to the LICENSE and NOTICE file problems in the
assemblies. These files were hiding in a corner of the svn tree where I
didn't spot the additional copies so they never got updated. I'll also
correct the problem with the mini-server version numbers at the same time.
I'm going to need some help from others to correct any of the other
issues, particularly the release notes. Those closest to the
information need to be providing the information we need to include,
particularly the information about the new commands. How long should I
hold the release open waiting for these additional items?
Rick
On 6/5/2010 12:09 PM, Kevan Miller wrote:
Source, signatures, and build all look good to me. Spot checks of jar file
legal information looks good. Assemblies start. I didn't run any extensive
tests, but didn't see any functional problems.
Major issues:
license/notice files in assemblies are different than the source license/notice files.
"different" is ok. The binary notice file is using a different format. I can
live with that. However, it seems to be missing content... I suspect that it's a NOTICE
file that we used for a G 2.1.x release...
For this reason, I'm -1 for release.
Minor issues, which, IMO, do not necessarily require fixing:
Binary distributions do not include any documentation. They should include
release notes/readme, etc. Information on how to run geronimo. Looks like the
2.2 releases didn't include this doc, either. We did in 2.1.x. Given new
commands, etc. Would be really good to have some documentation included in the
distribution... I could easily call this a major issue...
I get the following WARNINGS during server startup:
WARN [aries] Managed persistence context support is no longer available for
use with the Aries Blueprint container
WARN [StringManager] Can't find resource
org.apache.pluto.driver.container.LocalStrings
sun.misc.launcher$appclassloa...@553f5d07
WARN [SystemProperties] Existing Property=openejb.log.factory is already set
to Value=org.apache.openejb.util.PaxLogStreamFactory
WARN [XBeanNamespaceHandler] Could not load class:
org.apache.activemq.network.jms.JmsTopicConnector due to
org/springframework/jndi/JndiTemplate
2010-06-05 11:31:14,239 WARN [XBeanNamespaceHandler] Could not load class:
org.apache.activemq.spring.SpringSslContext due to
org/springframework/core/io/Resource
2010-06-05 11:31:14,242 WARN [XBeanNamespaceHandler] Could not load class:
org.apache.activemq.xbean.XBeanBrokerService due to
org/springframework/context/ApplicationContextAware
2010-06-05 11:31:14,276 WARN [XBeanNamespaceHandler] Could not load class:
org.apache.activemq.network.jms.JmsQueueConnector due to
org/springframework/jndi/JndiTemplate
2010-06-05 11:31:14,320 WARN [XBeanNamespaceHandler] Could not load class:
org.apache.activemq.spring.ActiveMQXAConnectionFactory due to
org/springframework/beans/factory/BeanNameAware
2010-06-05 11:31:14,452 WARN [XBeanNamespaceHandler] Could not load class:
org.apache.activemq.store.PersistenceAdapterFactoryBean due to
org/springframework/beans/factory/FactoryBean
2010-06-05 11:31:14,455 WARN [XBeanNamespaceHandler] Could not load class:
org.apache.activemq.spring.ActiveMQConnectionFactory due to
org/springframework/beans/factory/BeanNameAware
I get the following WARNING on server shutdown:
2010-06-05 11:31:21,230 WARN [aries] Managed persistence context support is no
longer available for use with the Aries Blueprint container
2010-06-05 11:31:21,263 WARN [context] The TransactionSynchronizationRegistry
used to manage persistence contexts is no longer available. Managed persistence
contexts will no longer be able to integrate with JTA transactions, and will
behave as if no there is no transaction context at all times until a new
TransactionSynchronizationRegistry is available. Applications using managed
persistence contexts may not work correctly until a new JTA Transaction
services implementation is available.
I get the following during shutdown of a jetty server:
2010-06-05 11:44:52,315 WARN [log] FAILED
org.eclipse.jetty.server.ser...@203feeda: java.lang.ExceptionInInitializerError
2010-06-05 11:44:52,316 ERROR [GBeanInstance] Problem in doStop of
org.apache.geronimo.configs/jetty8/3.0-M1/car?ServiceModule=org.apache.geronimo.configs/jetty8/3.0-M1/car,j2eeType=GBean,name=JettyWebContainer
java.lang.ExceptionInInitializerError
at org.eclipse.jetty.server.Server.doStop(Server.java:316)
at
org.eclipse.jetty.util.component.AbstractLifeCycle.stop(AbstractLifeCycle.java:80)
at
org.apache.geronimo.jetty8.JettyContainerImpl.doStop(JettyContainerImpl.java:289)
at
org.apache.geronimo.gbean.runtime.GBeanInstance.destroyInstance(GBeanInstance.java:1122)
at
org.apache.geronimo.gbean.runtime.GBeanInstanceState.attemptFullStop(GBeanInstanceState.java:340)
at
org.apache.geronimo.gbean.runtime.GBeanInstanceState.stop(GBeanInstanceState.java:189)
at
org.apache.geronimo.gbean.runtime.GBeanInstance.stop(GBeanInstance.java:552)
at
org.apache.geronimo.kernel.basic.BasicKernel.stopGBean(BasicKernel.java:430)
at
org.apache.geronimo.gbean.runtime.GBeanInstanceState.stop(GBeanInstanceState.java:181)
at
org.apache.geronimo.gbean.runtime.GBeanInstance.stop(GBeanInstance.java:552)
at
org.apache.geronimo.kernel.basic.BasicKernel.stopGBean(BasicKernel.java:430)
at
org.apache.geronimo.gbean.runtime.GBeanInstanceState.stop(GBeanInstanceState.java:181)
at
org.apache.geronimo.gbean.runtime.GBeanInstance.stop(GBeanInstance.java:552)
at
org.apache.geronimo.kernel.basic.BasicKernel.stopGBean(BasicKernel.java:430)
at
org.apache.geronimo.kernel.osgi.ConfigurationActivator.stop(ConfigurationActivator.java:93)
at
org.apache.felix.framework.util.SecureAction.stopActivator(SecureAction.java:683)
at org.apache.felix.framework.Felix.stopBundle(Felix.java:2128)
at org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1152)
at
org.apache.felix.framework.StartLevelImpl.run(StartLevelImpl.java:264)
at java.lang.Thread.run(Thread.java:637)
Caused by: java.lang.IllegalStateException: Shutdown in progress
at
java.lang.ApplicationShutdownHooks.add(ApplicationShutdownHooks.java:39)
at java.lang.Runtime.addShutdownHook(Runtime.java:192)
at
org.eclipse.jetty.util.thread.ShutdownThread.<init>(ShutdownThread.java:48)
at
org.eclipse.jetty.util.thread.ShutdownThread.<clinit>(ShutdownThread.java:36)
... 20 more
I noticed that for minimal server (jetty), ServerHostname is 0.0.0.0. For java
ee server (tomcat) ServerHostname defaults to localhost.
I'm tempted to start asking that releases be prepared on non-Windows machines
(or we should make some effort to keep Windows CR/LF line-endings out of our
files). There are a bunch of mixed-mode files in the binary distribution.
--kevan
On Jun 4, 2010, at 4:35 PM, Rick McGuire wrote:
I've managed to come up with a 3.0-M1 release candidate built using the
maven-release-plugin.
See the jira issues here:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12315090&styleName=Text&projectId=10220
Staged to
https://repository.apache.org/content/repositories/orgapachegeronimo-038/
The main artifacts up for vote are the source release archives
https://repository.apache.org/content/repositories/orgapachegeronimo-038/org/apache/geronimo/geronimo/3.0-M1/geronimo-3.0-M1-source-release.zip
https://repository.apache.org/content/repositories/orgapachegeronimo-038/org/apache/geronimo/geronimo/3.0-M1/geronimo-3.0-M1-source-release.tar.gz
If you vote you should at least examine these and make sure something plausible
builds from them.
The voting will be open a minimum of 72 hours.
[ ] +1 about time to push this out the door
[ ] 0 no opinion
[ ] -1 not this one (please explain why)
Rick