powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1055292190
########## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ########## @@ -16,15 +16,10 @@ */ package org.apache.xbean.finder.archive; -import org.acme.foo.Blue; Review Comment: but what are we fighting for in this place, for what values? in the main code it is clear: the shorter changes are, the faster they will be reviewed and comprehended. and here - do we save space in repository on the size of patches? in addition, the IDE sorts imports alphabetically. from my side, even if it happens from time to time it's more good than bad. p.s. can we discuss project structure by e-mail? spamcollector_@t_yandex.ru, if you don't mind -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
