powerbroker commented on code in PR #34:
URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051486174
##########
xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java:
##########
@@ -95,14 +96,65 @@ public void testIterator() throws Exception {
actual.add(entry.getName());
}
- assertFalse(0 == actual.size());
+ Assert.assertFalse(0 == actual.size());
for (Class clazz : classes) {
- assertTrue(clazz.getName(), actual.contains(clazz.getName()));
+ Assert.assertTrue(clazz.getName(),
actual.contains(clazz.getName()));
}
- assertEquals(classes.length, actual.size());
+ Assert.assertEquals(JarArchiveTest.classes.length, actual.size());
}
+ @Test
+ public void testXBEAN337() throws Exception {
Review Comment:
thanks, they helped to find/fix 1 issue.
can i ask you to integrate them?
cannot force my git to apply patch, so have to do it manually. and afraid it
will turn in too much cosmetics to fix...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
